Overhaul NSS UBSan check selection
Categories
(NSS :: Libraries, enhancement, P1)
Tracking
(Not tracked)
People
(Reporter: leander.schwarz, Assigned: djackson)
References
Details
(Keywords: sec-other)
Attachments
(1 file)
NSS UBSan builds currently have the following undefined behavior checks enabled by default (set in sanitizers.sh):
bool,signed-integer-overflow,shift,vptr
These are a small subset of all available checks, as well as a partial subset of the default Firefox UBSan build checks:
bool,bounds,enum,function,integer-divide-by-zero,object-size,pointer-overflow,return,vla-bound
The checks have been last updated in NSS 3.29 / 2017 and there has already been a undetected undefined behavior in NSS, which would have been detected with the 'pointer-overflow' check enabled.
=> The same default UBSan checks as in the Firefox builds should probably be enabled.
Assignee | ||
Updated•2 years ago
|
Assignee | ||
Comment 2•2 years ago
|
||
Assignee | ||
Comment 3•2 years ago
|
||
I spent some time looking at this and I think we can enable the default UBSan checks with a small amount of work. There's two outstanding issues which I've filed child bugs for. Further progress is blocked until fix up the current issues with the CI.
Updated•2 years ago
|
Assignee | ||
Comment 4•2 years ago
|
||
Updated•2 years ago
|
Updated•9 months ago
|
Description
•